fix(Invoice Ninja Node): Fix retrieving currencies for bank transactions #12997
+14
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Can you include some tests for this? Our contribution guide changed at the end of last year and tests are now a requirement for any PR. |
n8n-assistant
bot
added
community
|
Hey @CodeShakingSheep, Thanks for the PR, We have created "GHC-703" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
n8n-assistant
bot
added
the
in linear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
InvoiceNinja's currencies aren't retrieved correctly. That's why the list is empty, see screenshot.
I fixed the API call.
Related Linear tickets, Github issues, and Community forum posts
Follow-up of #10389
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)