fix(shopify): Get the next URL in pagination instead of previous one

[kodaho]

Summary

Shopify pagination in the REST API is handled by providing the next page URL in the link HTTP header. The next URL should be parsed from a string with the following format.

<https://shop.myshopify.com/admin/api/2024-07/products.json?limit=10&page_info=xxx>; rel="next"

The formula used to retrieve the URL was url.split('; ')[0].replace(...), which is OK in the above example.
The issue is that starting page 2, the header contains several links (a previous and a next one), with the following format:

<https://shop.myshopify.com/admin/api/2024-07/products.json?limit=10&page_info=xxx>; rel="previous", <https://shop.myshopify.com/admin/api/2024-07/products.json?limit=10&page_info=xxx>; rel="next"

With such value and by using the previous formula, the previous URL is retrieved instead of the next one, creating an infinite loop: on page 2, the next request will fetch information from page 1, then retrieve the next URL of page 2, only to re-return on page 1.

The proposed fix is to split the link header with , and filter on the links containing "next", and only after that, apply the formula.

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[CLAassistant]

All committers have signed the CLA.

[Joffcom]

Hey @kodaho,

Thanks for the PR, We have created "GHC-643" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

[kodaho]

Hi @Joffcom, thank you for the quick response and the information!

Since the workflows I’m working on rely on the Shopify nodes, I’ll explore whether there are alternative nodes that can provide the data I need.