Dependency updates: egui & ffmpeg #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps egui to 0.28.0 and ffmpeg-the-thrid to 2.0.1. This makes the project compatible with ffmpeg7.
The
input_context().packets()iterator now returns result items, for now I decided to just propagate them with?as is done elsewhere in the affected functions. Let me know if you think a different approach would be more suitable here.After the changes I ran the main example in this repo, everything seems to work fine. Tested on Arch with ffmpeg 7.0.1 installed.
From my understanding, the crate should still be compatible with ffmpeg6, but note that I haven't actually tested that.