-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroh): Enable netwatch::netmon::Monitor
and the metrics
feature in Wasm
#3206
Open
matheus23
wants to merge
12
commits into
main
Choose a base branch
from
matheus23/use-netwatch-wasm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+191
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`ActorSocketState::msock_socket_state`
8a5e6d0
to
b02cd72
Compare
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3206/docs/iroh/ Last updated: 2025-02-28T08:13:53Z |
6a14931
to
7ba2ac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
netwatch
dependency in Wasmnetwatch::netmon::Monitor
inmagicsock::Actor
metrics
feature for Wasm by depending on a newer iroh-metricsnetwatch::ip::is_unicast_link_local
, as we can depend on that in Wasm again now.Notes & open questions
There's some dependencies:
magicsock::SocketState
andActorSocketState
#3203 to be merged firstiroh-metrics
main branch (I.e. feat!: Split up themetrics
feature intometrics
andservice
iroh-metrics#11 being released)Closes #3195
Change checklist