Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh): Enable netwatch::netmon::Monitor and the metrics feature in Wasm #3206

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Feb 26, 2025

Description

  • Enables the netwatch dependency in Wasm
  • Un-cfg-s the netwatch::netmon::Monitor in magicsock::Actor
  • Enables the metrics feature for Wasm by depending on a newer iroh-metrics
  • Minor: We go back to using netwatch::ip::is_unicast_link_local, as we can depend on that in Wasm again now.

Notes & open questions

There's some dependencies:

Closes #3195

Change checklist

  • Self-review.

@matheus23 matheus23 self-assigned this Feb 26, 2025
@matheus23 matheus23 force-pushed the matheus23/use-netwatch-wasm branch from 8a5e6d0 to b02cd72 Compare February 26, 2025 15:14
Copy link

github-actions bot commented Feb 26, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3206/docs/iroh/

Last updated: 2025-02-28T08:13:53Z

Copy link

github-actions bot commented Feb 26, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 7f01ccd

@matheus23 matheus23 force-pushed the matheus23/use-netwatch-wasm branch from 6a14931 to 7ba2ac8 Compare February 26, 2025 16:11
Base automatically changed from matheus23/refactor-udpconn to main February 27, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

Implement online/offline detection in browsers
1 participant