feat(iroh): Make iroh compile to wasm32-unknown-unknown
#3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roh` in browsers" This reverts commit da63255.
matheus23
force-pushed
the
matheus23/browser
branch
from
d2a5ca6 to
160df40
Compare
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3189/docs/iroh/ Last updated: 2025-02-21T16:21:36Z |
matheus23
force-pushed
the
matheus23/browser
branch
from
674a083 to
160df40
Compare
matheus23
commented
Feb 20, 2025
Comment on lines
47
to
+49
| #[cfg(not(wasm_browser))] | ||
| pub mod dns; | ||
| pub mod node_info; |
There was a problem hiding this comment.
Moving node_info from crate::dns::node_info to crate::node_info, because we need it for discovery in browsers, but it's still nice to disable the whole dns module in browsers, too.
matheus23
commented
Feb 20, 2025
Comment on lines
-499
to
-507
| impl Drop for DiscoveryTask { | ||
| fn drop(&mut self) { | ||
| self.task.abort(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
DiscoveryTask::task is an AbortOnDropHandle.
dignifiedquire
approved these changes
Feb 21, 2025
This was referenced Feb 21, 2025
4 tasks
Frando
added a commit
to n0-computer/iroh-examples
that referenced
this pull request
Feb 25, 2025
This adds a new example: A chat app based on iroh gossip, running both in the browser and on the command line. See the README for details. * based on #106 for CI infrastructure added there * uses n0-computer/iroh#3189 and n0-computer/iroh-gossip#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(This PR is a rebase & some changes from the #3145 PR, so we don't disturb users who are trying out the iroh browser alpha.)
#[cfg(not(wasm_browser))]to anything related to socket networking (UDP sockets, DNS, etc.)WebRuntimefor quinn to use instead ofTokioRuntimein browsersbackoffthat work in browsersnode_infoout of thednsmodule, so we can disablednsas a whole, but keepnode_infofor discoveryMappedAddr::Ipin browsersBreaking Changes
iroh-relay: Theiroh_relay::dns::node_infomodule was moved toiroh_relay::node_infoNotes & open questions
I'm holding off on refactoring bigger parts for now. I have two main ideas:
magicsock.rs, i.e. everything that depends on sockets.However, to do this, I want to refactor the way we sometimes use
Arc<netwatch::UdpSocket>and sometimes useUdpConn, which is just a newtype over said type.Ideally we store
Arc<netwatch::UdpSocket>everywhere, since it's more commonly used in APIs, e.g. in iroh-net-report, and only useUdpConn, when we need the udp sockets to implementAsyncUdpSocketfrom quinn.node_infomodule so there's fewer places that depend onDnsResolverin it.There's a bunch of things in that module that IMO are needless indirections (we go from
hickory::TxtLookup->node_info::TxtAttrs<IrohAttr>->(NodeId, NodeData)->NodeInfo. And even then,NodeInfois mostly isomorphic toNodeAttr).I think both these refactors are helpful, but don't necessarily make the diff easier to read? Not sure. I'd like to merge this & then work on these refactors next week.
Change checklist