Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(bytes): bytes v1.6.0 was yanked so upgrade to bytes v1.6.1 #2503

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 15, 2024

Description

GitHub Actions cargo deny is failing at https://github.com/n0-computer/iroh/actions/runs/9928231752/job/27438879671

% cargo update -p bytes

    Updating crates.io index
     Locking 1 package to latest compatible version
    Updating bytes v1.6.0 -> v1.6.1
note: pass `--verbose` to see 152 unchanged dependencies behind latest

https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md to get the fix in

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please use the checkboxes though, it helps when looking at PRs on the overview.

@flub flub enabled auto-merge July 15, 2024 08:29
@flub flub added this pull request to the merge queue Jul 15, 2024
Merged via the queue into n0-computer:main with commit ecfbed3 Jul 15, 2024
28 checks passed
@cclauss cclauss deleted the bytes-v1.6.0-was-yanked branch July 15, 2024 09:10
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

<!-- A summary of what this pull request achieves and a rough list of
changes. -->
GitHub Actions `cargo deny` is failing at
https://github.com/n0-computer/iroh/actions/runs/9928231752/job/27438879671

% `cargo update -p bytes`
```
    Updating crates.io index
     Locking 1 package to latest compatible version
    Updating bytes v1.6.0 -> v1.6.1
note: pass `--verbose` to see 152 unchanged dependencies behind latest
```
https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md to get the
fix in
* tokio-rs/bytes#718
## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants