feat: Pluggable gc with exemptions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add ability to add excepmtions for gc before gc is started.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/17/docs/iroh_blobs/ Last updated: 2024-11-28T13:24:20Z |
|
The place where I tried this out is https://github.com/n0-computer/iroh-docs/tree/try-out-gc |
|
new api looks good |
matheus23
approved these changes
Nov 27, 2024
different way to deal with the clone madness Co-authored-by: Philipp Krüger <[email protected]>
first protect, then delete tag
# Conflicts: # src/net_protocol.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds gc to blobs so it does not have to be driven externally. A big complication is that we want to have the ability to add exemptions to gc, e.g. from docs or willow.
So the gc is initially not running when the Blobs object is created. We have the ability to add exemption callbacks in this stage. Once the setup is done you can (but don't have to!) start the gc loop, at which point adding exemptions is no longer possible.
Todo:
Breaking Changes
Notes & open questions
Change checklist