Skip to content

refactor: hide or remove unused code. #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2025
Merged

refactor: hide or remove unused code. #115

merged 4 commits into from
Jul 11, 2025

Conversation

rklaehn
Copy link
Collaborator

@rklaehn rklaehn commented Jul 11, 2025

Description

  • Hide the test module from docs (it will be removed/hidden behind afeature flag into a separate crate eventually.
  • Make util pub(crate)
  • Remove unused code in the hash_seq module

Breaking Changes

  • the util mod is no longer public
  • the test mod is hidden (will be non-public eventually)
  • there is a new reexport of ChunkRangeExt in protocol so people can use it

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

…feature flag into a separate crate eventually.

- Make util pub(crate)
- Remove unused code in the hash_seq module
Copy link

github-actions bot commented Jul 11, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/115/docs/iroh_blobs/

Last updated: 2025-07-11T15:28:25Z

rklaehn added 3 commits July 11, 2025 18:15
ChunkRangeExt is really the only thing we need out of util.

Eventually I might have to newtype ChunkRanges even though that would be a PITA.
people are confused how to obtain an API instance to work with, so this give them pointers.
@rklaehn rklaehn requested a review from b5 July 11, 2025 15:34
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything controversial here. Feel free to wait for a professional to approve first 😄

@rklaehn rklaehn merged commit d5bcbad into main Jul 11, 2025
23 of 24 checks passed
@rklaehn rklaehn deleted the hide-test-and-util branch July 11, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants