ci: fix release please #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
myyk
approved these changes
Oct 16, 2023
|
I think I messed up CI earlier when I fixed some other issues. So I'm gonna have to rollback some changes before merging this. CI started merging PRs with build failures. |
|
The failures seem related to permissions setup in my tests. I think it's safe to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should do the trick. Essentially, release please will run every time something is merged on
main, for everyfixandfeatcommits, it will generate a PR with the version.Then upon merging this PR onto
main, it will run the Release Please workflow again, this time creating the tags and the GitHub release.(The setup is a little annoying, but once setup, we never have to look back at it again :))