Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI which has been broken since v2 release #848

Merged
merged 9 commits into from
Oct 16, 2023
Merged

chore: fix CI which has been broken since v2 release #848

merged 9 commits into from
Oct 16, 2023

Conversation

myyk
Copy link
Owner

@myyk myyk commented Oct 16, 2023

This fixes the most broken issue about CI. There were some inputs not being set for that workflow.

I also had a lot of trouble setting the input.configPath as I couldn't use a spy to have it not just ignore the value outside of print statements. It was really annoying, so I had to do something where I explicitly set it. Even the ?? operator wasn't working with it.

@myyk myyk marked this pull request as ready for review October 16, 2023 09:21
@myyk myyk merged commit abc8f0e into main Oct 16, 2023
3 checks passed
@myyk myyk deleted the fix-ci branch October 16, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants