validate_xdg_dir_absolute() allocates a byte short when building the …

…string buffer in one of the code-paths.
mywave82 · Apr 1, 2024 · d1fc8df · d1fc8df
1 parent e4b6206
commit d1fc8df
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/boot/kickload-unix.c b/boot/kickload-unix.c
@@ -382,7 +382,7 @@ static char *validate_xdg_dir_absolute (const char *name, const char *def)
 	}
 	if (xdg)
 	{
-		char *retval = malloc (strlen (xdg) + 5);
+		char *retval = malloc (strlen (xdg) + 5 + 1);
 		if (retval)
 		{
 			sprintf (retval, "%s%socp/",
@@ -783,7 +783,7 @@ int validate_home(void)
 		char settingsPath[PATH_MAX];
 		if (find_directory(B_USER_SETTINGS_DIRECTORY, -1, false, settingsPath, sizeof(settingsPath)) == B_OK)
 		{
-			_cfConfigHomeDir = malloc (strlen (settingsPath) + 5);
+			_cfConfigHomeDir = malloc (strlen (settingsPath) + 5 + 1);
 			if (!_cfConfigHomeDir)
 			{
 				fprintf (stderr, "malloc() failed\n");