Fix strategy fifo as default if not defined. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fifo as default instead of lifo if it's not declared in pool args. This is so each connection will be used so we minimize connection timeout from mysql.
| %% We want strategy fifo as default instead of lifo. | ||
| PoolArgs1 = case proplists:is_defined(strategy, PoolArgs) of | ||
| true -> PoolArgs; | ||
| false -> PoolArgs ++ [{strategy, fifo}] |
There was a problem hiding this comment.
Hellre [{strategy, fifo} | PoolArgs]. Inte för prestandan (för PoolArgs är ändå inte extremt lång) men det är mer normalt att lägga till saker först i en lista.
I kommentaren, skriv gärna varför vi vill ha fifo, t.ex. så här:
%% Use fifo by default. MySQL closes unused connections after a certain time.
%% Fifo causes all connections to be regularily used which prevents them from
%% being closed.There was a problem hiding this comment.
Förresten, detta borde ligga i child_spec/3 istället för här.
|
👍 |
ghost
pushed a commit
that referenced
this pull request
Mar 3, 2015
…n-not-defined Fix strategy fifo as default if not defined.
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fifo as default instead of lifo if it's not declared in pool args.
This is so each connection will be used so we minimize connection timeout from mysql.