Add config for enriching activity with read-result-set-header #1538
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbeman
force-pushed
the
enrich-option
branch
from
bb01214 to
2005715
Compare
Signed-off-by: Tobias Laving <[email protected]>
Tobbeman
force-pushed
the
enrich-option
branch
from
2005715 to
7b67025
Compare
|
Thanks for the PR!
I noted on #1524 (comment) that Npgsql configures this on NpgsqlDataSourceBuilder (but didn't provide a concrete specification for MySqlConnector). Rather than adding more connection string options, I'd like to go this way instead (probably with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread: #1524
Inspiration here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/416/files
First PR, as far as I can tell the only configuration is done via the connection string to I kept using that pattern.
All feedback is appreciated.