[deploy-vhost] Allow multiple emails in crontab MAILTO #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
requested changes
Jun 24, 2022
bin/deploy-vhost
Outdated
| } elsif ($result != 0) { | ||
| warn "unexpected result code $result from lookup_google_apps_email.sh"; | ||
| my $found_external; | ||
| foreach my $mailto (split(',' $1)) { |
There was a problem hiding this comment.
is there a comma missing here? Even perl isn't this forgiving ;)
Cron permits a comma-separated list of emails in MAILTO, so we should support this too. The change will warn if none of the addresses are external.
sagepe
force-pushed
the
multiple-mails-in-cron
branch
from
52de00b to
de0ccdf
Compare
dracos
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cron permits a comma-separated list of emails in MAILTO, so we should support this too. The change will warn if none of the addresses are external.