Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bucks] Changes for 'Littering From Vehicles' category #5030

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea commented Jun 24, 2024

@nephila-nacrea nephila-nacrea self-assigned this Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (45557b3) to head (416133f).
Report is 12 commits behind head on master.

Files Patch % Lines
web/cobrands/fixmystreet/fixmystreet.js 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5030      +/-   ##
==========================================
+ Coverage   82.61%   82.97%   +0.35%     
==========================================
  Files         396      396              
  Lines       30810    31735     +925     
  Branches     4884     5041     +157     
==========================================
+ Hits        25454    26331     +877     
- Misses       3909     3954      +45     
- Partials     1447     1450       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nephila-nacrea nephila-nacrea changed the title [Bucks] Remove 'Please do not enter any personal...' msg for private … [Bucks] Changes for 'Littering From Vehicles' category Jun 26, 2024
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of small issues I think is all :)

perllib/FixMyStreet/Cobrand/Buckinghamshire.pm Outdated Show resolved Hide resolved
web/cobrands/fixmystreet/fixmystreet.js Show resolved Hide resolved
web/cobrands/fixmystreet/fixmystreet.js Outdated Show resolved Hide resolved
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, just one subsequent simplifying change

web/cobrands/fixmystreet/fixmystreet.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants