Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP WCAG page reflow #4981

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP WCAG page reflow #4981

wants to merge 2 commits into from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented May 30, 2024

Fixes: https://github.com/mysociety/societyworks/issues/4209

This PR looks to comply with the WCAG 1.4.10. Some px units haven been changed to REM, so they have a responsive behaviour. Also some improvements to the layout so users don't lose functionality when zooming in.

So far:

  • I have decreased the font-size for the html element when zooming in the text is not massive.
  • I have changed the the header units from PX to REM so the point above actually has also an impact on the logo.

Pending:

  • I need to discuss with Matthew the best approach for the around page. The fix above has generated that the following view, instead of just showing the the mobile map, which was the default behaviour when zooming in 400%. However we might need to change that behaviour because to fulfil the WCAG 1.4.10 criteria

Content can be presented without loss of information or functionality, and without requiring scrolling in two dimensions for:
Which is what is happening at the moment, where users zooming in can't see list of reports, as they could before zooming in.

Screenshot 2024-05-30 at 11 20 07

[Skip changelog]

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (269b6c9) to head (205ce86).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4981      +/-   ##
==========================================
+ Coverage   82.60%   85.29%   +2.68%     
==========================================
  Files         393      351      -42     
  Lines       30718    25633    -5085     
  Branches     4866     4866              
==========================================
- Hits        25376    21864    -3512     
+ Misses       3893     2320    -1573     
  Partials     1449     1449              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant