Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow h{1,2,3} tags in contact notices/questions #4959

Open
wants to merge 1 commit into
base: surrey-cobrand
Choose a base branch
from

Conversation

davea
Copy link
Member

@davea davea commented May 15, 2024

No description provided.

@davea davea force-pushed the surrey-html-tags-in-notices branch from dd34bad to 708849d Compare May 15, 2024 09:24
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (68cadc8) to head (708849d).

Additional details and impacted files
@@               Coverage Diff               @@
##           surrey-cobrand    #4959   +/-   ##
===============================================
  Coverage           82.57%   82.58%           
===============================================
  Files                 392      392           
  Lines               30504    30508    +4     
  Branches             4815     4815           
===============================================
+ Hits                25190    25194    +4     
- Misses               3879     3880    +1     
+ Partials             1435     1434    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davea davea marked this pull request as ready for review June 14, 2024 10:52
@davea davea requested a review from dracos June 14, 2024 10:52
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but if we're allowing this, we also need to fix the issue that notices appear in the front end wrapped in a needless <label> - which I don't think we want to have headings inside (I mean, shouldn't have the ones that are already allowed either!).

@dracos
Copy link
Member

dracos commented Jun 28, 2024

(I've made a commit now on surrey-cobrand that removes the label)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants