LNbits 0.12.x fixes #854

tlindi · 2024-03-07T16:35:34Z

Enhance MyNodeBTC to better support new LNbits features

Description

New LNbits versions after 0.12. have

A) new docker image name.
On vendor site new docker name lnbits instead old legend-lnbits
This PR changes docker image name to lnbits and there fore streamlines names.

B) configuration file.
.env has been included in mynodebtc setup. It doesn't reflect new features of lnbits.
During start of lnbits service the new .env -configuration file is created from vendor provided file (.env.example)

C) web admin UI.
It's more simple than making configuration changes onto .env file on Linux console.
We set admin UI enabled now by default. After clean install user must setup username and password for superuser.

D) functions to reset settings database and reveal superuser access key (usr ID)
Repairing corrupted or messed settings and viewing superuser usrID web access keys need access to Linux console and some long command. like:

/usr/bin/docker run --rm \
                              --name lnbits-superuser \
                              --volume /mnt/hdd/mynode/lnbits/.env:/app/.env \
                              --volume /mnt/hdd/mynode/lnbits/.super_user:/app/data/.super_user \
                              --volume /mnt/hdd/mynode/lnbits/:/app/data \
                              lnbits poetry run lnbits-cli superuser

/usr/bin/docker run --rm \
                              --name lnbits-delete-settings \
                              --volume /mnt/hdd/mynode/lnbits/.env:/app/.env \
                              --volume /mnt/hdd/mynode/lnbits/:/app/data \
                              lnbits poetry run lnbits-cli delete-settings

also file ".super_user" includes usrid when user has been created.
This PR provides LNbits tablet onto Settings page where node operator has buttons for above functions

This PR solves mostly issue #848

NOTE!

LNbits bug prevents resetting superuser password even with usr ID and delete-settings. LNbits issue lnbits/lnbits#2274

Implementation is rude IMHO, but it works for me now. And it has lot more to improve later on. One additional change could be enable/disable admin UI with the switch as a workaround for LNbits open issue above.

Checklist

tested successfully on local MyNode, if yes, list the device(s) below
mentioned related open issue, if any

List of test device(s)

Raspi4b

- change docker image name lnbits-legend to lnbits to match vendor naming

use .env.example from LNbits package as .env template

add LNbits to settings page, fetch superuser usr and reset database

tehelsper · 2024-03-24T22:12:41Z

rootfs/standard/usr/bin/service_scripts/pre_lnbits.sh

+fi
+
+# if current LNbits version config is missign create .env from .env.example 
+if [ ! -f /mnt/hdd/mynode/lnbits/update_config_$LNBITS_VERSION ]; then


Typically, I would create a version number to track config updates so that it doesn't update automatically each upgrade / lnbits version change.

Shouldn't the .env template be updated on each update so new options and defaults would be corrected on update too?

There are version files from Application Management related to installed, latest and available version. Could those be used as reference here too?

It normally doesn't need to be updated for each new release. Normally, the software should account for "missing" settings in the config file to use the default anyway. Keeping the file around makes it easy to update the default settings and control how the app runs. Those files just control the application version and not the settings files. There are examples in a few places, like pre_rtl.sh.

RTL_CONFIG_UPDATE_NUM=1 if [ ! -f /mnt/hdd/mynode/rtl/update_settings_$RTL_CONFIG_UPDATE_NUM ]; then cp -f /usr/share/mynode/RTL-Config.json /mnt/hdd/mynode/rtl/RTL-Config.json touch /mnt/hdd/mynode/rtl/update_settings_$RTL_CONFIG_UPDATE_NUM fi

tehelsper · 2024-03-24T22:14:53Z

rootfs/standard/usr/bin/service_scripts/pre_lnbits.sh

-    cp /usr/share/mynode/lnbits.env /mnt/hdd/mynode/lnbits/.env
+# Delete old myNode .env file created before 0.12.x
+if [ -f /usr/share/mynode/lnbits.env ]; then
+    rm -f /usr/share/mynode/lnbits.env


I'd rather not get rid of this file since I can control it a bit better and reference the config. Can it just be updated with the latest version from the lnbits repo? If I do have to put in default settings, this file (/usr/share/mynode/lnbits/env) is a nice way to do it.

Will fix the way you suggested

tlindi · 2024-04-02T07:56:12Z

LNbits version bump 0.12.4 to be added later.
Great oppornity to test upgrade process too.

tehelsper · 2024-04-13T04:15:21Z

rootfs/standard/var/pynode/device_info.py

+#==================================
+# LNbits Functions
+#==================================
+def delete_lnbits_settings():


I also don't think this would work. It looks like this launches a new container rather than running a command in the existing lnbits container.

Have you tried it? It may work by launching a second container. Alternatively, you could exec into the running container to run the command, but I guess that would only clear the settings if lnbits was actively running.

tehelsper · 2024-04-13T04:19:06Z

rootfs/standard/var/www/mynode/api.py

+        info = ""
+
+        info += to_string(subprocess.check_output("cat /mnt/hdd/mynode/lnbits/.super_user", shell=True))


Where does this file that stored the super_user info get created? I only see it getting read/deleted.

Oh, it looks like it file is created by lnbits.

tehelsper · 2024-04-22T04:59:28Z

I tested this and ported a subset of the changes in 75a2a38

The old config seems to still work well.

Rename lnbits-legend docker to lnbits

3758364

- change docker image name lnbits-legend to lnbits to match vendor naming

tlindi force-pushed the LNbits-0.12.x-fixes branch from 8fb040d to 3676e59 Compare March 7, 2024 16:55

tlindi added 2 commits March 7, 2024 20:12

Fix LNbits .env creation

736541a

use .env.example from LNbits package as .env template

Add LNbits lnbits-cli delete-settings and superuser

d9cc901

add LNbits to settings page, fetch superuser usr and reset database

tlindi force-pushed the LNbits-0.12.x-fixes branch from 3156c6d to d9cc901 Compare March 7, 2024 18:12

tehelsper requested changes Mar 24, 2024

View reviewed changes

tehelsper reviewed Apr 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LNbits 0.12.x fixes #854

LNbits 0.12.x fixes #854

tlindi commented Mar 7, 2024 •

edited

Loading

tehelsper Mar 24, 2024

tlindi Apr 2, 2024

tehelsper Apr 13, 2024

tehelsper Mar 24, 2024

tlindi Apr 2, 2024

tlindi commented Apr 2, 2024

tehelsper Apr 13, 2024

tehelsper Apr 13, 2024

tehelsper Apr 13, 2024

tehelsper Apr 13, 2024

tehelsper commented Apr 22, 2024

		info = ""

		info += to_string(subprocess.check_output("cat /mnt/hdd/mynode/lnbits/.super_user", shell=True))

LNbits 0.12.x fixes #854

Are you sure you want to change the base?

LNbits 0.12.x fixes #854

Conversation

tlindi commented Mar 7, 2024 • edited Loading

Description

Checklist

List of test device(s)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tlindi commented Apr 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tehelsper commented Apr 22, 2024

tlindi commented Mar 7, 2024 •

edited

Loading