Various dependency updates #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnybot0
commented
Sep 7, 2022
| public class AwsS3BuildCacheServiceFactory implements BuildCacheServiceFactory<AwsS3BuildCache> { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(AwsS3BuildCacheServiceFactory.class); | ||
|
|
||
| @Nonnull |
There was a problem hiding this comment.
This change was strictly to avoid a warning in IntelliJ. Shameless drive-by change, I know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using this plugin for a bit (as noted in the discussion in #15). I started noticing this in my gradle output:
This seems to be a side effect of a resolved bug in the AWS SDK. I started out doing the work to update the AWS SDK. Then I got carried away and updated the Gradle version used, which required updating the shipkit plugins.
If you need this broken up into distinct PRs, or if there's additional work you'd like done to merge these changes, that's fine by me.
I figure this might necessitate a minor version bump, or possibly even just calling this a 1.0 seeing as we've been successfully using it for nearly 3 years. :)
FWIW, I did test these changes in our project that's using this plugin, and it worked fine.