Fix for verify=False ignoring #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzkostyan
requested changes
Mar 5, 2024
| @@ -70,6 +70,7 @@ jobs: | |||
| run: | | |||
| echo "VERSION=${{ matrix.clickhouse-version }}" > tests/.env | |||
| if [[ "${{ matrix.clickhouse-version }}" > "21.7" ]]; then echo "ORG=clickhouse"; else echo "ORG=yandex" ; fi >> tests/.env | |||
| if [[ "21.10" = "`echo -e "21.10\n${{ matrix.clickhouse-version }}" | sort -V | head -n1`" ]]; then echo "TOP_LEVEL=clickhouse"; else echo "TOP_LEVEL=yandex" ; fi >> tests/.env | |||
There was a problem hiding this comment.
Can we replace "21.10" = "``echo -e "21.10\n${{ matrix.clickhouse-version }}" | sort -V | head -n1``" with "${{ matrix.clickhouse-version }}" >= "21.10"?
And the same in another place.
There was a problem hiding this comment.
No, we cannot. Because bash makes alphanumeric comparison, not version-wise. Please check if [[ "21.9" < "21.12" ]]; then echo "fine"; else echo "fail"; fi
tests/test_connect.py
Outdated
| @@ -306,6 +306,11 @@ def test_client_revision(self): | |||
| with self.created_client(client_revision=54032) as client: | |||
| client.execute('SELECT 1') | |||
|
|
|||
| def test_client_with_no_cert_validation(self): | |||
| with self.created_client(port=9440, | |||
There was a problem hiding this comment.
Let's:
- add
secureport=9440intosetup.cfg; - add attribute
secure_portto classtests.testcase.BaseTestCase; - use
self.secure_porthere instead of hardcoding.
| @@ -8,6 +8,10 @@ services: | |||
| - TZ=Europe/Moscow | |||
| ports: | |||
| - "127.0.0.1:9000:9000" | |||
| - "127.0.0.1:9440:9440" | |||
There was a problem hiding this comment.
We should add port 9440 in development docs: docs/development.rst:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
flake8and fix issues.pytestno tests failed. See https://clickhouse-driver.readthedocs.io/en/latest/development.html.