WIP: Feature/fix infra spatialite #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om blacksheep framework. most of these layers do not have to be tied to a framework's folder. any other framework can simply consume these layers as well
…sing functionality to make tests green
…heir type annotaitons. added e2e api testing support in start_server and conftest. added unit test configuration setup in pyproject. ignore any db files in project
…st-integration marker WIP. adds support for test markers
…app level infra setup using DI using rodi's Container that sets up database and session
…B. refactored code to use container to setup database using start_test_database and asyncSetUp. WIP: test_fetch_facilities
Unstable, active and WIP: This is where things start taking shape for setting test coverage `GeoLocationServiceSqlRepoDBTest` to implement issue: #26 ; - major rewrite of test services for integration test for Sqlite Repo DB. refactored code to use container to setup database using start_test_database and asyncSetUp. WIP: test_fetch_facilities - added sqlite models to support sqlite database. database.py enhances app level infra setup using DI using rodi's Container that sets up database and session
…abels are created in container and spatialite is loaded successfully
Reviewer's Guide by SourceryThis pull request introduces changes to fix the spatialite extension loading issue to support the POINT data type in SQLAlchemy models. The changes include updating the Dockerfile setup, implementing correct spatialite extension loading with aiosqlite compatibility, and temporarily disabling an integration test. The PR also adds new functionality to the Provider model and makes adjustments to related tests and configurations. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @codecakes - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- UUID generation at import time may cause duplicate IDs (link)
Overall Comments:
- Consider re-enabling the integration tests as soon as possible to ensure continued code quality and prevent regressions.
- Ensure that the addition of the available_doctors field to the Provider model is reflected and handled appropriately throughout the codebase.
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue, 1 other issue
- 🟢 Security: all looks good
- 🟡 Review instructions: 1 issue found
- 🟡 Testing: 2 issues found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
change datatype to reflect column type Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
|
codecakes
added a commit
that referenced
this pull request
Sep 22, 2024
Introduces changes to fix spatialite extension loading issue to support data fields in sqlachemy model type `POINT`. This change directly supports the work in #26 - Fixes spatialite extension as loadable with the updated dockerfile setup and correct implementation using aiosqlite compatibility - Temporary disables integration test. The repository return type needs to be refactored and return type changed to list dto facilities results <!-- Generated by sourcery-ai[bot]: start summary --> Fix SpatiaLite extension loading issue to support spatial data fields in SQLAlchemy models. Introduce a new `PointType` for handling geopoint data. Refactor test database setup and temporarily disable integration tests pending refactoring. Update build scripts and Makefile for improved Docker handling. New Features: - Introduce a new `PointType` class to handle geopoint data types in SQLAlchemy models, enabling support for spatial data fields like `POINT`. Bug Fixes: - Fix the loading of the SpatiaLite extension in the database setup to support spatial data operations. Enhancements: - Refactor the test database setup to use a new `SetUpTestDatabase` class, improving the management of test database lifecycle and session handling. Build: - Update the Makefile to include a new `set-docker` target and modify the `docker-run-server` target to remove orphan containers. Tests: - Temporarily disable integration tests due to the need for refactoring repository return types and changing return types to list DTO facilities results. Chores: - Update the `run.sh` script to include additional logging for file listing and database removal. <!-- Generated by sourcery-ai[bot]: end summary --> --------- Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces changes to fix spatialite extension loading issue to support data fields in sqlachemy model type
POINT. This change directly supports the work in #26Summary by Sourcery
Fix SpatiaLite extension loading issue to support spatial data fields in SQLAlchemy models. Introduce a new
PointTypefor handling geopoint data. Refactor test database setup and temporarily disable integration tests pending refactoring. Update build scripts and Makefile for improved Docker handling.New Features:
PointTypeclass to handle geopoint data types in SQLAlchemy models, enabling support for spatial data fields likePOINT.Bug Fixes:
Enhancements:
SetUpTestDatabaseclass, improving the management of test database lifecycle and session handling.Build:
set-dockertarget and modify thedocker-run-servertarget to remove orphan containers.Tests:
Chores:
run.shscript to include additional logging for file listing and database removal.