fix phpunit on modern php

mygento · Aug 7, 2024 · e5c5674 · e5c5674
1 parent ffb6e32
commit e5c5674
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/grumphp.yml b/.github/workflows/grumphp.yml
@@ -15,7 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ['8.0', '8.1', '8.2', '8.3']
+        php-versions: ['8.1', '8.2', '8.3']
     steps:
       - uses: actions/checkout@v4
 

diff --git a/Controller/Adminhtml/Event.php b/Controller/Adminhtml/Event.php
@@ -55,6 +55,7 @@ public function __construct(
     protected function initPage($resultPage)
     {
         $resultPage->setActiveMenu('Mygento_Base::event');
+
         //->addBreadcrumb(__('Event'), __('Event'));
         return $resultPage;
     }

diff --git a/Test/Unit/DiscountHelper/SplitItemsTest.php b/Test/Unit/DiscountHelper/SplitItemsTest.php
@@ -42,7 +42,7 @@ public function testCalculation($order, $expectedArray)
         $recalcExpectedItems = array_values($expectedArray['items']);
 
         foreach ($recalcItems as $index => $recalcItem) {
-            $this->assertEquals($recalcExpectedItems[$index]['price'], $recalcItem['price'], 'Price of item failed');
+            $this->assertEqualsWithDelta($recalcExpectedItems[$index]['price'], $recalcItem['price'], 0.001, 'Price of item failed');
             $this->assertEquals($recalcExpectedItems[$index]['quantity'], $recalcItem['quantity']);
             $this->assertEquals($recalcExpectedItems[$index]['sum'], $recalcItem['sum'], 'Sum of item failed');
         }

diff --git a/Test/Unit/DiscountHelper/SpreadAndSplitTest.php b/Test/Unit/DiscountHelper/SpreadAndSplitTest.php
@@ -40,7 +40,7 @@ public function testCalculation($order, $expectedArray)
         $recalcExpectedItems = array_values($expectedArray['items']);
 
         foreach ($recalcItems as $index => $recalcItem) {
-            $this->assertEquals($recalcExpectedItems[$index]['price'], $recalcItem['price'], 'Price of item failed');
+            $this->assertEqualsWithDelta($recalcExpectedItems[$index]['price'], $recalcItem['price'], 0.001, 'Price of item failed');
             $this->assertEquals($recalcExpectedItems[$index]['quantity'], $recalcItem['quantity']);
             $this->assertEquals($recalcExpectedItems[$index]['sum'], $recalcItem['sum'], 'Sum of item failed');
         }

diff --git a/Test/Unit/Facade/AllHandlersTest.php b/Test/Unit/Facade/AllHandlersTest.php
@@ -49,7 +49,7 @@ public function testCalculation($order, $expected, $virtualOrder = null, $taxVal
 
         foreach ($result->getItems() as $key => $recalcItem) {
             $expectedItem = array_shift($expectedItems);
-            self::assertEquals($expectedItem['price'], $recalcItem->getPrice(), $key . ' Price of item failed');
+            self::assertEqualsWithDelta($expectedItem['price'], $recalcItem->getPrice(), 0.001, $key . ' Price of item failed');
             self::assertEquals($expectedItem['tax'] ?? null, $recalcItem->getTax(), $key . ' Tax of item failed');
             self::assertEquals($expectedItem['quantity'], $recalcItem->getQuantity());
             self::assertEquals($expectedItem['sum'], $recalcItem->getSum(), $key . ' Sum of item failed');