Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added code 100 to allowed http statuses #39

Open
wants to merge 1 commit into
base: v2.3
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Model/Atol/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Client
const REQUEST_TEST_URL = 'https://testonline.atol.ru/possystem/v%u/';

//see Atol Documentation
const ALLOWED_HTTP_STATUSES = [200, 400, 401];
const ALLOWED_HTTP_STATUSES = [100, 200, 400, 401];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not authorize this modification without official protocol documentation provided

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no mention about code #100 in official doc. :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На мой взгляд, фикс должен быть более кардинальным. Нттр коды, в нашем случае, нестабильная вещь, их меняют без предупреждения и соотв документации.


const GET_TOKEN_URL_APPNX = 'getToken';
const SELL_URL_APPNX = 'sell';
Expand Down