Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designandcodesmells #3303

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Designandcodesmells #3303

wants to merge 4 commits into from

Conversation

nav2508
Copy link

@nav2508 nav2508 commented Nov 28, 2024 •
edited
Loading

  1. Performed Extraction of Method
  2. Renamed Variable
  3. Decomposed Conditional
  4. Extracted Class
  5. Replaced Conditional with Polymorphism
  6. Moved Fields

@harawata
Copy link
Member

Hello @nav2508 ,

This is just a quick note, but please do not delete comments and code that are marked as "deprecated".

In general, it is better to submit one group of changes in one PR rather than submitting one pull request contains various changes.
The latter is harder to review and we rarely accept all changes.

And, please make it a "draft PR" if it's not ready.
If you keep adding commits, we do not know when to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nav2508 @harawata