-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show response length in check.sh #19
Conversation
This reverts commit e02e1e0.
Now it's showing a very small difference, from 34 to 32 bytes. Still they need to return the same response, but it's very similar. But sometimes can be a big diff, and it's best to fix it. |
Seems that this small difference is from the |
Still we have the URL length difference, in the request. |
2 bytes seems insignificant, but in a bench exist a big difference. These 2 bytes in pure-php will be a drop of ~1.600 req/s. |
no idea about slim but that is the reason to have |
The problem is that a lot of people use a I'm tired to explain it:
But to be useful, we need to measure the data correctly. |
In a benchmark all need to return the same response length.
For now it's only for information, so the dev can fix it.
PD: the length is calculated only for ASCII, that for this bench is correct