Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony update to v6.3 #17

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Symfony update to v6.3 #17

merged 4 commits into from
Jul 26, 2023

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Jul 25, 2023

No description provided.

@myaaghubi myaaghubi changed the base branch from main to dev July 25, 2023 06:09
@myaaghubi
Copy link
Owner

myaaghubi commented Jul 25, 2023

Didn't check it yet, however, guessing just the version number changed (on the folder name and in the setup.sh)
for this kind things we may use git mv oldfolder newfolder
Edit: plz consider PRs to dev branch

@joanhey
Copy link
Contributor Author

joanhey commented Jul 25, 2023

Yes I created the branch from the dev, and later send PR to main 🤭

@joanhey
Copy link
Contributor Author

joanhey commented Jul 25, 2023

It's rare that worked without the change in the benchmark.config.

PD: yes, in the first commit I didn't move the dir and send the deleted dir 🤭.
It is not good to write code, when it's too late.

@myaaghubi
Copy link
Owner

myaaghubi commented Jul 26, 2023

I checked it are you sure it is passing check.sh ?
edit: sorry for being late, busy these days

@joanhey
Copy link
Contributor Author

joanhey commented Jul 26, 2023

Yes, It's OK
image

@joanhey
Copy link
Contributor Author

joanhey commented Jul 26, 2023

Now any change that break, will not pass the GH action check.

@myaaghubi
Copy link
Owner

then it is a glitch on my machine, ok I'll make sure later

@myaaghubi myaaghubi merged commit be0f200 into myaaghubi:dev Jul 26, 2023
1 check passed
@joanhey
Copy link
Contributor Author

joanhey commented Jul 26, 2023

mmmm I'll check again

Update: It's OK

@joanhey joanhey deleted the sym-6.3 branch July 26, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants