Add Codeigniter 3.1 #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Later I'll try to add GHactions tests. |
|
Not a PR but PRs, if the speed between CI3/CI4 is different then that's useful to have CI3 in the table too, however the latest results are for PHP 8.2, so official support for it is necessary. Consider the right version after PHP 8.2 get supported |
|
We can check first the PHP version, and if PHP8.2 by pass CI3 for now, till they merge the fix. |
|
When this PR bcit-ci/CodeIgniter#6173 is merged. |
|
We moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI4 is five times slower than CI3, and they need to fix this performance regression.
Also I know this bench, because one notification in the issue that I created in CI4 about that regression.
CI3 don't work with php8.2 (exist a PR that fix that, but it isn't merged yet), but anybody can try it with with other versions.
Will be very useful for the CI core developers.
The problem, is that we need to change the
parse_results()to by pass any framework that fail in any version.