Skip to content

Commit

Permalink
Merge #658
Browse files Browse the repository at this point in the history
658: fix: fixed for the issue (#657) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [ ] Yes, this is a breaking change.
- [x] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/twitter-dart/twitter-api-v2/issues
[contributor guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/CONTRIBUTING.md
[style guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <[email protected]>
  • Loading branch information
bors[bot] and myConsciousness authored Feb 27, 2023
2 parents 85840bf + 7a58577 commit 712cc1d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release Note

## v4.9.4

- Fixed some named parameters as nullable. ([#657](https://github.com/twitter-dart/twitter-api-v2/issues/657))

## v4.9.3

- Added `exclude` parameter to `TweetsService.lookupQuoteTweets`. ([#647](https://github.com/twitter-dart/twitter-api-v2/issues/647))
Expand Down
9 changes: 4 additions & 5 deletions lib/src/service/lists/lists_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ abstract class ListsService {
required String listId,
int? maxResults,
String? paginationToken,
List<TweetExpansion> expansions,
List<TweetExpansion>? expansions,
List<TweetField>? tweetFields,
List<UserField>? userFields,
Paging<List<TweetData>, TweetMeta>? paging,
Expand Down Expand Up @@ -760,8 +760,8 @@ abstract class ListsService {
required String listId,
int? maxResults,
String? paginationToken,
List<UserExpansion> expansions,
List<UserField> userFields,
List<UserExpansion>? expansions,
List<UserField>? userFields,
Paging<List<UserData>, UserMeta>? paging,
});

Expand Down Expand Up @@ -826,7 +826,6 @@ abstract class ListsService {
/// `PaginationControl.stop()` to terminate paging on
/// arbitrary conditions, otherwise paging continues until the
/// next page runs out.
///
/// ## Endpoint Url
///
Expand Down Expand Up @@ -1027,7 +1026,7 @@ abstract class ListsService {
required String listId,
int? maxResults,
String? paginationToken,
List<UserExpansion> expansions,
List<UserExpansion>? expansions,
List<TweetField>? tweetFields,
List<UserField>? userFields,
Paging<List<UserData>, UserMeta>? paging,
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: twitter_api_v2
description: The most famous and powerful Dart/Flutter library for Twitter API v2.0.
version: 4.9.3
version: 4.9.4
repository: https://github.com/twitter-dart/twitter-api-v2
issue_tracker: https://github.com/twitter-dart/twitter-api-v2/issues
homepage: https://github.com/twitter-dart
Expand Down

0 comments on commit 712cc1d

Please sign in to comment.