Draft: Previously selected proposal gets automatically selected on new login by another user #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
168
to
169
| :param str login_id: username | ||
| :param str password: password |
There was a problem hiding this comment.
Comment on lines
321
to
323
| :param str user: representation of (patial) username and nickname of new user | ||
| :param str password: password | ||
| :param dict lims_data: dictionary with the lims data to be updated |
There was a problem hiding this comment.
If there are type hints, then there is no need to add the type in the docstring as well. Type hint annotation is preferred and enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.