Ensure we set jupytext metadata to model #1197
Conversation
* When selectedFormts are empty, we return before setting jupytext metadata * So, the changes are not being comitted to notebook model * This commit fixes it by ensuring we always set metadata before returning * Use console.debug instead of console.log to reduce log pollution Signed-off-by: Mahendra Paipuri <[email protected]>
|
Thank you for making this pull request. Did you know? You can try it on Binder: Also, the version of Jupytext developed in this PR can be installed with (this requires |
|
@mwouts Could you please test this patch and see if it fixes the bug? Cheers!! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 29 29
Lines 4456 4456
=======================================
Hits 4355 4355
Misses 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mwouts Just a gentle reminder in case you missed it during the holidays. If confirm that this patch fixes the bug, we can go for a merge! |
|
Thank you @mahendrapaipuri ! Yes I have finally tested this PR on Binder - sorry for the long delay - and I can confirm that it works. I will take it tomorrow (after #1204 or #1190 which I need to fix the CI). |
The bug shows up when the user unpairs all the formats. It is reproducible in both notebook and JupyterLab.
Fixes #1191