Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up testing infra #388

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Clean up testing infra #388

wants to merge 3 commits into from
+36 −96

Conversation

mvukov
Copy link
Owner

@mvukov mvukov commented Oct 10, 2024 •
edited
Loading

Turns out --sandbox_default_allow_network=false does all necessary job and we don't need domain_id shenanigans.

@ahans @lalten PTAL.

lalten
lalten approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@lalten lalten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We already set --sandbox_default_allow_network=false on our side.

ahans
ahans approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ahans ahans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fine, but I would keep the local domain for testing to not mandate this Bazel setting from downstream projects. Also I'm not sure what'd happen if you bazel run a test. With the local domain it'll always work....

ros2/pytest_wrapper.py.tpl
@@ -41,28 +39,22 @@ def main() -> None:
if 'ROS_LOG_DIR' not in os.environ:
os.environ['ROS_LOG_DIR'] = bazel_test_output_dir

with contextlib.ExitStack() as stack:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this as an extra line of defense. I also find it good practice to use tempfile and not rely on Bazel for stuff like this. But if you really like it, we can always patch locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahans ahans ahans approved these changes

@lalten lalten lalten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvukov @ahans @lalten