Webhook management #683
Open
Webhook management #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvisonneau
approved these changes
Oct 1, 2023
There was a problem hiding this comment.
thanks a lot for this feature @blaketigges and sorry for not taking the time to look into it earler. There are a few nits regarding nomenclature which I feel would be easier for users to leverage the solution. Happy to look into it if you do not plan to work further onto this though.
| @@ -50,6 +50,23 @@ server: | |||
| # environment variable) | |||
| secret_token: 063f51ec-09a4-11eb-adc1-0242ac120002 | |||
|
|
|||
| add_webhooks: | |||
There was a problem hiding this comment.
Suggested change
| add_webhooks: | |
| manage_projects: |
Comment on lines
+64
to
+65
| # GCPE Webhook endpoint URL | ||
| webhook_url: https://gcpe.example.net/webhook |
There was a problem hiding this comment.
Suggested change
| # GCPE Webhook endpoint URL | |
| webhook_url: https://gcpe.example.net/webhook | |
| # GCPE Webhook endpoint URL accessible from GitLab | |
| advertised_url: https://gcpe.example.net/webhook |
Comment on lines
+67
to
+68
| # Whether to remove webhooks when GCPE shutsdown | ||
| remove_webhooks: false |
There was a problem hiding this comment.
Suggested change
| # Whether to remove webhooks when GCPE shutsdown | |
| remove_webhooks: false | |
| # Whether or not to remove webhooks when GCPE shuts down | |
| remove_on_delete: false |
| return err | ||
| } | ||
|
|
||
| WURL := c.Config.Server.Webhook.URL |
There was a problem hiding this comment.
Suggested change
| WURL := c.Config.Server.Webhook.URL | |
| webhookURL := c.Config.Server.Webhook.URL |
|
I don't have the environment set up anymore for testing, can you look into it? |
|
no worries, will do thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature to allow gcpe to add webhooks to every project added by name or wildcard then have the option to remove them on shutdown.