Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error-prone logging #15

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Fix error-prone logging #15

merged 1 commit into from
Mar 6, 2025

Conversation

mvinyard
Copy link
Owner

@mvinyard mvinyard commented Mar 6, 2025

  • Removed faulty logging statements that were being called upon __init__ of inheriting classes. This would cause stricter requirements on the order of operations during __init__, which is not convenient and often causes problems with backwards-compatibility.

@mvinyard mvinyard added bug Something isn't working enhancement New feature or request labels Mar 6, 2025
@mvinyard mvinyard merged commit 4aa8e4c into main Mar 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant