Skip to content

Fixed wrong proxy keyword (httpx) #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smorrin28
Copy link

Reverted PR #1149 since HTTPX now uses the keyword "proxy" instead of "proxies" (https://www.python-httpx.org/advanced/proxies/) to create any proxy values, this always throws an error when creating an AsyncTransport object if using the latest httpx version.

@Silverdoses
Copy link

Thanks for the PR. I ran into this issue today as well:

TypeError: Client.__init__() got an unexpected keyword argument 'proxies'

For additional context: the proxies keyword argument was deprecated in earlier versions of httpx and was removed entirely in version 0.28.0

This fix will solve issues when upgrading to latest version of httpx as dependency for other packages, like in my case.

@smorrin28
Copy link
Author

As a temporary fix I just directly created the wsdl client and passed it as an argument:

httpx_client = ...
wsdl_client = httpx.Client(verify=True, proxy=None, timeout=300)
client = AsyncClient(self._base_url, transport=AsyncTransport(client=httpx_client, wsdl_client=wsdl_client))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants