Network Change Events #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFKevinRef
reviewed
Nov 24, 2025
| prototype.beaconIntervalHandler = sub(beaconIntervalEvent) | ||
| data = beaconIntervalEvent.getData() | ||
| m.updateSessionPropertiesConnectionType() | ||
| m._checkNetworkChange() |
There was a problem hiding this comment.
Is it possible to use EnableLinkStatusEvent and/or EnableInternetStatusEvent for this instead of just checking on the beacon interval?
Collaborator
There was a problem hiding this comment.
I'd suggest something like this if it would work, as well, so we don't have a rendezvous every time we check the beacon interval. I know with the other performance improvements we've helped, but it would be good to not add back in rendezvous if we don't have to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes requested in here
We are now firing an initial change event when we start a view and we are polling to check for changes in the network, if the connection type changes, we fire a
networkchangeevent containing the connection type