Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed/sdk-ng build, merging back to test branch #30

Open
wants to merge 4 commits into
base: ed/sdk-ng
Choose a base branch
from
Open

ed/sdk-ng build, merging back to test branch #30

wants to merge 4 commits into from

Conversation

eropple
Copy link
Contributor

@eropple eropple commented Mar 30, 2021

No description provided.

@eropple eropple changed the title DO NOT MERGE ed/sdk-ng build, merging back to test branch Mar 30, 2021
james-mux
james-mux approved these changes Apr 6, 2021
View reviewed changes
Copy link

@james-mux james-mux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks good! I can pull it down and try it out if you'd like to be certain, but style-wise I haven't seen anything which looks like a major no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-mux james-mux james-mux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eropple @james-mux