-
Notifications
You must be signed in to change notification settings - Fork 59
feat(themes): expose centered layout #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(themes): expose centered layout #1183
Conversation
@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
{{>TitleDisplay}} | ||
</media-control-bar> | ||
<div slot="centered-chrome" class="center-controls"> | ||
<div slot="centered-chrome" part='centered-layer' exportparts="centered-layer" class="center-controls"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be reverted.
the exportparts
goes on the web component which has the shadow dom which contains the CSS part so for this case it's the media-controller element but as you can see it already exports centered-layer
.
maybe it's not exported on media-theme
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I revert those changes and move the filter property to the button so the reporter can use to
mux-player::part(center play button) { shadow: none; filter: none; }
to remove the filter (shadow) to the button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a correct css part export
<div | ||
slot="centered-chrome" | ||
part="centered-layer" | ||
exportparts="centered-layer" | ||
class="center-controls pre-playback" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert as well
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
+ Coverage 70.73% 70.77% +0.04%
==========================================
Files 37 37
Lines 6676 6683 +7
Branches 498 501 +3
==========================================
+ Hits 4722 4730 +8
+ Misses 1951 1949 -2
- Partials 3 4 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The center controls also have other buttons besides the play button so this won't work properly yet. Could you check if media-theme is exporting that css part already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves Issue 1174 by:
• Add to the centered-chrome
• Exposed this centered-layout element for styling and customization.
Usage:
Add style to remove filter to centered-layer children as
mux-player::part(centered-layer) { filter: none; }