Skip to content

Conversation

ronalduQualabs
Copy link
Contributor

@ronalduQualabs ronalduQualabs commented Aug 12, 2025

Resolves Issue 1174 by:

• Add to the centered-chrome

the part centered-layout in both classic and gerwig themes.
• Exposed this centered-layout element for styling and customization.

Usage:

Add style to remove filter to centered-layer children as

mux-player::part(centered-layer) { filter: none; }

@ronalduQualabs ronalduQualabs requested a review from a team as a code owner August 12, 2025 14:42
@ronalduQualabs ronalduQualabs marked this pull request as draft August 12, 2025 14:42
Copy link

vercel bot commented Aug 12, 2025

@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

snyk-io bot commented Aug 12, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ronalduQualabs ronalduQualabs marked this pull request as ready for review August 20, 2025 14:23
@luwes luwes changed the title Feat/themes expose centered layout feat(themes): expose centered layout Sep 5, 2025
{{>TitleDisplay}}
</media-control-bar>
<div slot="centered-chrome" class="center-controls">
<div slot="centered-chrome" part='centered-layer' exportparts="centered-layer" class="center-controls">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be reverted.

the exportparts goes on the web component which has the shadow dom which contains the CSS part so for this case it's the media-controller element but as you can see it already exports centered-layer.

maybe it's not exported on media-theme ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revert those changes and move the filter property to the button so the reporter can use to

mux-player::part(center play button) { shadow: none; filter: none; }

to remove the filter (shadow) to the button

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a correct css part export

Comment on lines 1035 to 1040
<div
slot="centered-chrome"
part="centered-layer"
exportparts="centered-layer"
class="center-controls pre-playback"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert as well

Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.77%. Comparing base (75451bb) to head (8cedf2f).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
+ Coverage   70.73%   70.77%   +0.04%     
==========================================
  Files          37       37              
  Lines        6676     6683       +7     
  Branches      498      501       +3     
==========================================
+ Hits         4722     4730       +8     
+ Misses       1951     1949       -2     
- Partials        3        4       +1     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The center controls also have other buttons besides the play button so this won't work properly yet. Could you check if media-theme is exporting that css part already?

@ronalduQualabs ronalduQualabs requested a review from luwes October 6, 2025 18:58
Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to remove box-shadow from center-controls?

2 participants