Skip to content

Commit

Permalink
feat: Add volume slider to live controls (#800)
Browse files Browse the repository at this point in the history
The live version of the new theme has a mute button but no volume
slider. This is actually how it is in the designs but I think it's an
omission and a customer asked where it was. Have added it back in and
uncommented out the live preview in our vanilla example.
  • Loading branch information
AdamJaggard authored Oct 24, 2023
1 parent 954b2c8 commit 5e0c337
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions examples/vanilla-ts-esm/public/mux-player.html
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ <h1><a href="/">Elements</a></h1>
playback-id="23s11nz72DsoN657h4314PjKKjsF2JG33eBQQt6B95I"
></mux-player>

<!-- <mux-player
<mux-player
stream-type="live:dvr"
playback-id="v69RSHhFelSm4701snP22dYz2jICy4E4FUyk02rW4gxRM"
title="My amazing video"
></mux-player> -->
></mux-player>

<a href="../">Browse Elements</a>
</body>
Expand Down
2 changes: 1 addition & 1 deletion packages/mux-player/src/themes/gerwig/gerwig.html
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@
{{>PlayButton}}
<template if="targetlivewindow > 0"> {{>SeekBackwardButton}} {{>SeekForwardButton}} </template>
</template>
{{>MuteButton}}
{{>MuteButton}} {{>VolumeRange}}
<div class="spacer"></div>
{{>RenditionSelect}} {{>AudioTrackSelect}} {{>CaptionsMenuButton}} {{>AirplayButton}} {{>CastButton}}
<template if="breakpointsm">{{>PipButton}}</template>
Expand Down

5 comments on commit 5e0c337

@vercel
Copy link

@vercel vercel bot commented on 5e0c337 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-vanilla – ./examples/vanilla-ts-esm

elements-demo-vanilla-mux.vercel.app
elements-demo-vanilla-git-main-mux.vercel.app
elements-demo-vanilla.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 5e0c337 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-svelte-kit – ./examples/svelte-kit

elements-demo-svelte-kit-mux.vercel.app
elements-demo-svelte-kit-git-main-mux.vercel.app
elements-demo-svelte-kit.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 5e0c337 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-create-react-app – ./examples/create-react-app-with-typescript

elements-demo-create-react-app-mux.vercel.app
elements-demo-create-react-app-git-main-mux.vercel.app
elements-demo-create-react-app.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 5e0c337 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-nextjs – ./examples/nextjs-with-typescript

elements-demo-nextjs-git-main-mux.vercel.app
elements-demo-nextjs-mux.vercel.app
elements-demo-nextjs.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 5e0c337 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

elements-demo-vue – ./examples/vue-with-typescript

elements-demo-vue.vercel.app
elements-demo-vue-mux.vercel.app
elements-demo-vue-git-main-mux.vercel.app

Please sign in to comment.