electron wrapper #64
Open
electron wrapper #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Gonna test it out on a Windows and Linux and see if it works... |
|
Right on. Let me know if there are any issues. electron-boilerplate uses electron-builder, which supports creating installers on all 3 major platforms. |
|
Works fairly well. I'm going to add a way to open external links in a separate browser. And a popup for the Reddit log in. Otherwise, this could use some extra desktop-only features that I'll look into. |
|
let me know if I can help with any features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #63
Electron wrapper for reddit music player.
Most of the code was generated by electron-boilerplate. Very little was changed, other than removing unused scrips / styles / html.
https://reddit.musicplayer.iodirectlyRequires python 2.7 because of node-gyp. Other than that, dev environment with
npm start. Build (unsigned) installers withnpm run release.