-
Notifications
You must be signed in to change notification settings - Fork 1
Markdown engine / Image rendering #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,756
−866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add an example presentation so we have a common ground for what we are rendering |
Loading status checks…
96784ca
to
1c291c0
Compare
c6a420a
to
e03261b
Compare
wip: logging wip: remove preRender frame and add demo cache wip: successfull image rendering
- Extendable parser that returns nodes that a renderer can consume - Node types for available features (Images, CodeBlocks) and default Glamour node
Loading status checks…
Loading status checks…
…ry + doc strings
Loading status checks…
Loading status checks…
Loading status checks…
Loading status checks…
Loading status checks…
Loading status checks…
Loading status checks…
…al does not support it
tharropoulos
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny little changes 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds image rendering along with a refactor to the markdown parsing engine.
Markdown Architecture
Parser:
Trigger()
method to identify the specific byte that activates its parsing logicRenderer:
The
Renderer
consumes the nodes generated by the parser and generates the proper output