More chord parenthesis tweaks #30566
Merged
+15
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjustment was absolutely negligible on MacOS (about 0.1556 in our internal units which is ~0.006 of a "regular" spatium). It was also much larger and very incorrect on Windows and Linux.
its-not-nice
added
the
engraving
its-not-nice
approved these changes
Oct 16, 2025
Merged
cbjeukendrup
approved these changes
Oct 20, 2025
mike-spa
reviewed
Oct 20, 2025
| double TextSegment::bboxBaseLine() const | ||
| { | ||
| FontMetrics fm(m_font); | ||
| return boundingRect().bottom() - fm.descent(); |
There was a problem hiding this comment.
Yeah I must say this didn't look quite right, cause the font descent is fixed but the bottom of the bounding rect depends on the actual characters 👍
mike-spa
approved these changes
Oct 20, 2025
github-project-automation
bot
moved this from In Progress
to Needs porting
in MuseScore Studio 4.6.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Inconsistent height on Windows & Linux
Resolves: Inconsistent thickness on all systems
Before:
After:
