Reduce horizontal padding for full measure rests #30553
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29719
As mentioned by @its-not-nice here, since version 4.6 full measure rests can tuck inside the other voice's notes, but they need to do so with some horizontal margin on each side, or they would risk getting buried. It doesn't matter what we set that margin to, it will always be possible to construct situations like those shown in the issue where one case falls just above and the other just below the margin thus producing different results.
However, the current margin of 4sp on each side was probably overly cautious. Reducing the margin should make these kind of situations less likely (although, as said, still technically unavoidable).