Fix building with Visual Studio #27856
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -242,4 +242,8 @@ if (NOT MSVC AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VER | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-copy") | |||
| endif (NOT MSVC AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 9.0) | |||
|
|
|||
| if (MSVC) | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj") | |||
There was a problem hiding this comment.
Suggested change
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj") | |
| add_compile_options("/bigobj") |
or
Suggested change
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj") | |
| target_compile_options(notation PRIVATE "/bigobj") |
but then it needs to be after setup_module().
Or you could decide to make it global, and put the add_compile_options version in SetupBuildEnvironment. Perhaps that's best, but I'm not very sure. I don't know how big the downsides of this /bigobj option are. (If it's only that we can't use pre-2005 linkers with it, then we would surely be able to live with it, but it's unclear whether that's the whole story.)
By the way, I guess that the root cause is that the files become too large because of unity build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed this build error(s):
Similar to #21018