Fix #27633: Prevent triggering note input mode when app window is not in focus #27776
Conversation
RomanPudashkin
force-pushed
the
accidental_note_input
branch
from
1a0de4c to
8abc754
Compare
| return false; | ||
| } | ||
|
|
||
| if (hasSelection() && !noteOrRestSelected()) { |
There was a problem hiding this comment.
This condition seems new to me. Is it new desired behaviour? (Not sure how nice that is...)
There was a problem hiding this comment.
I see it probably comes from
Note input with a computer or MIDI keyboard should only work when a note, rest, or measure is selected.
I think that is only about when pressing a note name keyboard shortcut. But entering note input mode by explicitly clicking the note input button or by pressing N or M, should stay possible, whatever is selected.
There was a problem hiding this comment.
Yes: start note input only when a note, rest, or nothing is selected. To prevent it from starting when you have a text element selected (let's say lyrics, in that case, it deletes the lyrics for some reason) for example. Either way it should be tested for usability
There was a problem hiding this comment.
I think that is only about when pressing a note name keyboard shortcut. But entering note input mode by explicitly clicking the note input button or by pressing N or M, should stay possible, whatever is selected.
I asked @bkunda about this, and he said we should have the same consistent behaviour for both MIDI & computer keyboards
There was a problem hiding this comment.
Yes, typing an A on the computer keyboard should do the same as typing an A on the MIDI keyboard (namely nothing, unless we are already in note input mode or a note or rest is selected).
But Bradley said nothing about starting note input explicitly by pressing N or M, or by pressing a button in the toolbar. So, that should remain possible, regardless of whatever is selected.
Resolves: #27633