Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidying up colors and prettify frames #26326

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mike-spa
Copy link
Contributor

@mike-spa mike-spa commented Feb 4, 2025

Resolves: #26171

At the moment we have the following color definitions:

  • Formatting color (defaults to bright pink)
  • Frame color (defaults to grey)
  • Invisible color (defaults to another grey)

Some items need a grey color, but that color is not conceptually related to either invisible elements nor frames, and it shouldn't change if users for some reason decide to change frame color or invisible color from the preferences. So I've introduced a further color definition, called

  • Score grey color

which defaults to the same grey as the frame color but is not editable (in other words, it's hardcoded).

Here's a summary of the whole thing.

  • Selected grip handle: formatting color ❌ ➡️ Changed to score grey
  • Slur/tie editing lines: formatting color ❌ ➡️ Changed to score grey
  • Irregular measures: formatting color ✅
  • Layout breaks / System locks / Spacers: formatting color ✅
  • Staff type change: formatting color ✅
  • Atonal key signature in palette: formatting color ❌ ➡️ Changed to score grey
  • Page margins: formatting color ❌ ➡️ Changed to score grey
  • Page number in navigator: formatting color ❌ ➡️ Changed to score grey
  • Text editing frame: frame color ✅
  • Frames: frame color ✅
  • Figured bass extensione lines: frame color ❌ ➡️ Changed to invisible color

While I was at it, I took the opportunity to try to prettify frames by

  • Slightly decreasing the line width (now at 0.1 staff spaces)
  • Increasing the dash size
  • Using round caps and round joins

Copy link
Contributor

@jessjwilliamson jessjwilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Formatting color' in Advanced preferences is applied incorrectly to some elements
3 participants