Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notarize all macOS builds except PRs #26309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jojo-Schmitz
Copy link
Contributor

and not just nightly builds

I understand that for PRs this is not going to happen for security reasons, but for pushes it should be as save as for nightly builds.

@cbjeukendrup
Copy link
Contributor

For us, this shouldn't make a different right? Because we don't build on push events.

Also, it looks like Apple won't be particularly happy when people push a lot of useless builds to their notarisation servers (https://developer.apple.com/forums/thread/124958, see the post by "DTS Engineer"). Of course, there will never be incredibly many pushes per day, so I'm not really against this PR, but it is something to keep in mind. There is a kind of rate limit of 75 notarisations per day. Worst case scenario is that they somehow detect something as abuse and end your developer account, but that won't happen very soon I think.

@Jojo-Schmitz
Copy link
Contributor Author

Oh, I wasn't aware that you don't build on push events.
But as long as it doesn't impose any danger, I'd rather enable it for my 3.x, as it eases the testing.

and not just nightly builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants