Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #24630: Failure to load MuseSampler patches after instrument change #26275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mathesoncalum
Copy link
Contributor

Resolves: #24630

In our current system, every Drumset we create starts off as an MS Basic patch and only becomes a MuseSampler patch once a mixer channel has been created for it (see usage of shouldLoadDrumset in PlaybackController). Due to the fact that we don't create new channels for identical instruments in a given part, the knock-on effect is that the new drumset won't have a chance to load a MuseSampler patch.

This PR does a couple of things:

  1. If we try to change to a Drumset that already exists in the given part, we'll copy the patch from the existing Drumset
  2. Changes to a Drumset (e.g. notehead changes) are copied for all identical Drumsets in a given part.

In an ideal world, we could avoid this "manual syncing" by having Instruments share pointers to the same Drumset. Doing so would require an extensive overhaul of much of our Instrument/Drumset logic, so we'll save this for another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change instrument back and forth between same two instruments doesn't load MuseSounds drum maps
1 participant