Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17549: Prevent MIDI KeyUp-event from executing mapped command #26270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niklas-simon
Copy link

Resolves: #17549

When mapping a command to a MIDI button, the command is executed both for press and release. This PR fixes the issue by checking the velocity of the button press.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

…eMeasures

Fix system locks on remove measures
@niklas-simon niklas-simon force-pushed the 17549-midi-prevent-double-fire branch from 155b74e to 3b21544 Compare January 29, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping MIDI button executes command twice - on both press and release
2 participants