Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15726 (Spacers): Some elements are lost when changing time signature #26263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pacebes
Copy link
Contributor

@pacebes pacebes commented Jan 28, 2025

Resolves: #15726 (Spacers)

This PR keeps as much Spacers as possible when changing time signature

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@pacebes
Copy link
Contributor Author

pacebes commented Jan 28, 2025

Two Scores to test the PR with duplicate Scores to facilitate testing are provided: Score_15726_spacers_tests.zip

@pacebes pacebes force-pushed the 15726-someElementsLostWhenChangingTimeSignature_Spacers branch from 16df3db to 2166d77 Compare January 28, 2025 21:11
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some elements are lost when changing time signature
1 participant