Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuning temperaments plugin fix #26257

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Tuning temperaments plugin fix #26257

wants to merge 18 commits into from
+712 −4,475

Conversation

Ash-86
Copy link

@Ash-86 Ash-86 commented Jan 27, 2025 •
edited
Loading

I had accidentally rebsed the branch in the old pr, and it closed automatically after i tried resetting. Couldnt reopen so i opened this one instead - sorry :(

  • The "annotation" option is fixed.
  • There are currently 3 tuning/temperaments plugins (tuning, modal tuning, and modal temperaments). They are the same plugin with different lists of temperaments. I merged them into a single plugin. The temperamentes are now organized by tab for western and middle eastern temperaments.
  • replaced broken "save" functionality with "add/remove temperament".
  • updated ui with MU components.
  • removed superflous redo/undo functions and cleaned up code.

Ash-86 added 18 commits November 28, 2024 17:55
@Ash-86
annotation function fixed
1c08dd2
@Ash-86
cleaned up code
da7060f
@Ash-86
merged 3 plugins in 1 and updated UI
74e0c27 
modal temperaments, tuning, and modal tuning are merged into 1 plugin. Temperaments are organized by tab (western/middle eastern temperaments).  Added currentTab data to history for proper "undo/redo" function.
updated ui with MU components.
@Ash-86
deleted other temperament plugins as they were merged into the 1st.
80eb1a2
@Ash-86
replaced pageTabButtons with delegate. Renamed temperaments. fixed se…
cd0ed7d 
…tCurrentTemperament, checkCurrentTemperament and lookUpTemperament functons accordingly.
@Ash-86
Changed ScrollView to StyledListView
8c092c8
@Ash-86
Rewritten file Save functionality, now with autosave. New items can n…
1e6283b 
…ow be added/removed dynamically by user.
@Ash-86
replaced pureTone buttons with delegate
6c2e044
@Ash-86
replaced rootNote buttons with deletage
615d5ee
@Ash-86
auto-select after add temperament. adjusted some names.
dd1a091
@Ash-86
load file on run.
d284859
@Ash-86
removed parts related to history functionality.
db94bc7
@Ash-86
changed finalOffsets textfields to delegate. cleaned code.
7e3e641
@Ash-86
Changed TextField to TextInputField
5cd994d
@Ash-86
cleaned code, removed unused functions, merged simple functions.
1dab1c6
@Ash-86
fixed fileIO url
d10b00c
@Ash-86
select added temperament; select the previous temperament after remove.
355889e
@Ash-86
updated add dialog to MUui
73ee4ed
@Ash-86
Copy link
Author

Ash-86 commented Jan 27, 2025

output.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ash-86